Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: publish new version of npm package #941

Open
danielnixon opened this issue Jan 1, 2025 · 2 comments
Open

Request: publish new version of npm package #941

danielnixon opened this issue Jan 1, 2025 · 2 comments

Comments

@danielnixon
Copy link
Contributor

See #936 (comment) and #933 (comment)

@gijsk
Copy link
Contributor

gijsk commented Jan 2, 2025

This makes sense to me - I have merged some PRs and updated the changelog in preparation for this. But I'm wondering about fixing e.g. the typescript bits before pushing another release. There are some other open PRs as well, unfortunately some need significant reviewing/rebasing and/or fixing up to merge, which is a bit unfortunate. I'm also going to have to take a health break for a bit starting tomorrow. Will let the other maintainers know if I take too long to get back. If you get a chance to submit a PR for the typescript stuff (I tried to investigate but got pretty confused because it seems typescript 1 and 2 treat null values for typed properties differently?) then I'd be happy to try to get that merged.

@danielnixon
Copy link
Contributor Author

Thanks @gijsk, I appreciate all your help. Please don't feel any time pressure from me. I'll get a PR up for the TypeScript tweak in the new few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants