Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 experimental #11

Open
Shrhawk opened this issue Jan 3, 2017 · 3 comments
Open

python3 experimental #11

Shrhawk opened this issue Jan 3, 2017 · 3 comments

Comments

@Shrhawk
Copy link

Shrhawk commented Jan 3, 2017

I need this package for python3 so download it using:
pip install git+https://github.com/mpetazzoni/ptftpd@master

While downloading the file using the get method here it throws following error:
lib/python3.5/site-packages/ptftplib/proto.py", line 139, in createRRQ
struct.error: argument for 's' must be a bytes object

Is this package is ready for python3 or not ?

@mpetazzoni
Copy link
Owner

Python3 support is still under development. There has been some recent contributions to improve Python3 compatibility but it might not all be there yet. If you have time, I'd love to review PRs that continue on this path and make ptftpd work with Python3!

@mpetazzoni
Copy link
Owner

The just-released version 1.3 (on PyPI), or master, should work now with Python 3. Thanks for reporting!

@uSpike
Copy link
Contributor

uSpike commented Jun 21, 2019

It seems that python3 is still not supported. There's various errors in dhcp:

ptftplib/dhcpserver.py", line 175, in __init__
    if ord(pkt[9]) != IP_UDP_PROTO:
TypeError: ord() expected string of length 1, but int found

@mpetazzoni mpetazzoni reopened this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants