Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Class variables should either be made private or made into properties #12

Open
relativityspace-jsmith opened this issue Jan 2, 2025 · 0 comments

Comments

@relativityspace-jsmith
Copy link
Collaborator

Being honest, when I wrote this library originally, I did not really follow good practice with class variables. I made all the variables "public" (i.e. not starting with an underscore), so linters won't complain if other code uses then. And some of these class variables are used, especially the list of sockets (which is needed by users of multicast_expert who want to select multiple sockets at a time or set socket options).

What we need to do is make all the current class variables private, and then add property getters for any of the variables which external code has a legitimate reason to be using.

Note that this could end up being a non backwards compatible change which triggers a 2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant