Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generated parameter command names should use PRM instead of PARAM #561

Open
bocchino opened this issue Jan 8, 2025 · 3 comments · May be fixed by #562
Open

Auto-generated parameter command names should use PRM instead of PARAM #561

bocchino opened this issue Jan 8, 2025 · 3 comments · May be fixed by #562
Assignees
Labels
bug Something isn't working code generation Issues related to code generation
Milestone

Comments

@bocchino
Copy link
Collaborator

bocchino commented Jan 8, 2025

For compatibility with the XML autocoder. See nasa/fprime#3116.

@zimri-leisher
Copy link

One comment--this might have been caught if there were a .seq file being fprime-seqgen'd as part of CICD. Maybe consider adding that to check for future regressions like this?

@bocchino
Copy link
Collaborator Author

bocchino commented Jan 8, 2025

I think it would be sufficient for the Ref integration test to set and save a parameter. Right now it's not doing that.

https://github.com/nasa/fprime/blob/devel/Ref/test/int/ref_integration_test.py

@zimri-leisher
Copy link

zimri-leisher commented Jan 8, 2025

Ah, I was wrong, it does actually use seqgen as part of CICD. However, seqgen doesn't include the PRM SET commands. Maybe the easiest fix is to just add a param set cmd to the seq:
https://github.com/nasa/fprime/blob/devel/Ref/test/int/test_seq.seq

But your alternative also works, and seems like it addresses the issue more directly.

@jwest115 jwest115 linked a pull request Jan 8, 2025 that will close this issue
@jwest115 jwest115 moved this from To do to In progress in FPP Fixes and Enhancements Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code generation Issues related to code generation
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants