Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an auth or timeout failure happens each subtask still runs #255

Closed
jeffkala opened this issue Oct 11, 2024 · 1 comment
Closed

When an auth or timeout failure happens each subtask still runs #255

jeffkala opened this issue Oct 11, 2024 · 1 comment
Assignees
Labels
type: bug Something isn't working as expected

Comments

@jeffkala
Copy link
Contributor

Environment

  • Python version: 3.11
  • Nautobot version: 2.2
  • nautobot-device-onboarding version: 4.0.1
  • ntc-templates version: 6.0

Expected Behavior

Might be solved by a connectivity check; however, if a timeout happens on the first command execution for timeout or auth failure all subsequent commands shouldn't be attempted as it causes unnecessary failures and login attempts.

Observed Behavior

If auth fails, it tries to login and run show version, and then even if auth fails on the first command it does the same for the remaining commands.

Steps to Reproduce

  1. Run sync devices job on with purposefully bad credentials
  2. Will see the same auth failure occur for every command.

Probably makes sense here to add a connecitivyt check + logic to say if the first command fails with (timeout, auth) to stop and don't runn the other commands.

Potentially create our own connection handling on the nornir side.

@scetron
Copy link
Contributor

scetron commented Dec 10, 2024

Fixed by #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants