Added prefetching of tags to ViewSet classes for all objects #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #239
What's Changed
Tags are now included in the response to API requests for the nautobot_firewall_models objects. I had suggested the changes to support this in a comment on issue 239 previously and one of my suggestions was incorporated already - adding TaggedModelSerializerMixin to all the classes that inherit from NautobotModelSerializer in nautobot_firewall_models/api/serializers.py. However, the other half of the changes I described to support adding the tags in API responses wasn't added yet. This consists of adding '.prefetch_related("tags")' to the end of the "objects.all()" line in each of the corresponding ViewSet classes in nautobot_firewall_models/api/views.py. That's what is included in this PR.
To Do
None