Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lingering processes for Gatsby telemetry and Jest worker #1896

Closed
ehmicky opened this issue Oct 1, 2020 · 1 comment · Fixed by #1897
Closed

Fix lingering processes for Gatsby telemetry and Jest worker #1896

ehmicky opened this issue Oct 1, 2020 · 1 comment · Fixed by #1897
Assignees
Labels
proj/lingering-processes type: chore work needed to keep the product and development running smoothly

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Oct 1, 2020

In #1889, we moved the lingering processes from the buildbot to Netlify Build.
The logic is currently the same. However, it happens a few seconds earlier.

It turns out some lingering processes are short-lived and terminate within a few seconds. Those were previously not reported to users due to the small duration between the end of the build command and the lingering process logic, which allowed them to complete. Now that this duration is smaller, they are being reported.

Ideally, those processes should be reported to the user and terminated, as mentioned in https://github.com/netlify/buildbot/issues/984

However, in order to decrease the amount of surprise for users for this specific release, I would suggest not reporting any warnings for the time being, for the top two offenders:

  • Gatsby telemetry: node_modules/gatsby-telemetry/lib/send.js
  • Jest child processes still running: node_modules/jest-worker/build/workers/processChild.js
  • Broccoli Babel plugin: broccoli-babel-transpiler (known bug from that plugin)

We can then fix each of those libraries separately.

@ehmicky ehmicky added type: feature code contributing to the implementation of a feature and/or user facing functionality epic/bp2/on-success labels Oct 1, 2020
@ehmicky ehmicky self-assigned this Oct 1, 2020
@ehmicky ehmicky reopened this Oct 1, 2020
@ehmicky ehmicky added proj/lingering-processes type: chore work needed to keep the product and development running smoothly and removed epic/bp2/on-success proj/bp2/build-plugins-v2 type: feature code contributing to the implementation of a feature and/or user facing functionality labels Oct 12, 2020
@ehmicky ehmicky removed their assignment Oct 12, 2020
@ehmicky ehmicky self-assigned this Mar 30, 2021
@ehmicky
Copy link
Contributor Author

ehmicky commented Mar 30, 2021

Done

@ehmicky ehmicky closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proj/lingering-processes type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants