Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve warnings message color #2389

Closed
ehmicky opened this issue Mar 10, 2021 · 2 comments · Fixed by #2470
Closed

Improve warnings message color #2389

ehmicky opened this issue Mar 10, 2021 · 2 comments · Fixed by #2470
Assignees
@ehmicky
Labels
proj/lingering-processes type: chore work needed to keep the product and development running smoothly

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Mar 10, 2021 •
edited
Loading

Background at #2371

The lingering processes message is a warning, not an error. Its color should be yellow, not red.

We should use this new warning color for other warnings in @netlify/build and @netlify/config as well.
@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Mar 10, 2021
@ehmicky ehmicky self-assigned this Mar 10, 2021
@ehmicky ehmicky mentioned this issue Mar 10, 2021
Closed
@ehmicky ehmicky mentioned this issue Mar 24, 2021
Merged
@ehmicky
Copy link
Contributor Author

ehmicky commented Mar 24, 2021 •
edited
Loading

Related PRs at #2468 and #2469

This was referenced Mar 24, 2021
Merged
Merged
@ehmicky
Copy link
Contributor Author

ehmicky commented Mar 24, 2021

Done at #2470.

@ehmicky ehmicky changed the title Improve lingering processes message color Improve warnings message color Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehmicky ehmicky

Labels
proj/lingering-processes type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: distinguish between warnings and errors in build logs netlify/build
1 participant
@ehmicky