images are not processed #187

navaki · 2022-09-05T15:35:45Z

A few images inserted via the RTE are not displayed in the frontend, it seems that the path is not resolved correctly, because in the src part a URL like "typo3/image/process?token=1a372fa4f26ec25d0b49ef1317e04233eab325fb&id=28234" is displayed.
Looks like that in the frontend, of course:

However, a few images are displayed correctly - what could be the reason?

Also, in the backend, when uploading, the message "The validation of the security token of this form has failed. Please reload the form and submit it again." - is this possibly related?

Edit:
This occurs with Typo3 Version 11.5.15 and rte_ckeditor_image in Version 11.0.5 (PHP 8.0)

cschnell · 2022-09-06T09:55:49Z

I can confirm this Issue. To me it seems as if this only happens to editors, not to admins. The tag that I can see when switching the RTE to source code mode looks like this:
<img alt="" data-alt-override="true" data-htmlarea-file-table="sys_file" data-htmlarea-file-uid="16188" data-title-override="true" height="750" src="https://<mydomain>/typo3/image/process?token=4c12de5113a30c7c5dc33e4af404c25ba8746317&id=32133" title="" width="1000" />

The currently installed version is 11.0.5 with TYPO3 11.5.15 and PHP 8.0

navaki · 2022-09-19T10:00:11Z

Problem occurs in Typo3 Version 11.5.16, too.
Replacing lost images with new reference fixes this Problem temporarly, but after saving the container a second time they disappear again.

jpmschuler · 2022-10-28T11:15:51Z

Same on PHP 7.4

jpmschuler · 2022-10-29T20:23:05Z

Ok, did my best for a proposal #194 that doesn't need to re-save each an every "contaminated" RTE field.
Perhaps this might help you too. I don't have much insight into RTE post processors, but the solution seems plausible

this fixes netresearch#187 The situation is as follows: starting with 11LTS in the backend processed images get not a `/fileaadmin/_processed/` "resulting image" style url but a new `/typo3/image/process?token` "middleware" style url. However that is only available for logged in BE users. Thus this can be saved to RTE and displayed there, however will break the frontend output. Now I tried to fix what is saved in the backend/db, but came to the conclusion that this shouldn't be the aim, as there are probably reasons for the backend using that new URL. Thus my approach here is to accept this new URL, accept the "bug" that this new URL gets converted to an absolute URL and rather tackle the problem while generating frontend output, where the generation is skipped formerly, because it sees "external URL". Now an if just checks for the string `'/typo3/image/process?token'` and starts reprocessing.

cschnell · 2022-10-31T15:26:23Z

I have added the patch to my system and will provide feedback, when tested.

this fixes #187 The situation is as follows: starting with 11LTS in the backend processed images get not a `/fileaadmin/_processed/` "resulting image" style url but a new `/typo3/image/process?token` "middleware" style url. However that is only available for logged in BE users. Thus this can be saved to RTE and displayed there, however will break the frontend output. Now I tried to fix what is saved in the backend/db, but came to the conclusion that this shouldn't be the aim, as there are probably reasons for the backend using that new URL. Thus my approach here is to accept this new URL, accept the "bug" that this new URL gets converted to an absolute URL and rather tackle the problem while generating frontend output, where the generation is skipped formerly, because it sees "external URL". Now an if just checks for the string `'/typo3/image/process?token'` and starts reprocessing.

navaki · 2022-11-08T09:51:01Z

I tested the bugfix on my local system - unfortunately it did not solve the problem for me.
@cschnell is your problem fixed?

jpmschuler · 2022-11-08T09:58:04Z

n.b.:

To be fair I also added [BUGFIX] fileadmin path without slash won't output in 11LTS #197 to my installs before running all tests, but that is rather for really legacy RTE content and shouldn't affect this.
I didn't see any change at all for multiple scenarios as this seemed to be cached on different levels. I really need to force-clear the whole cache and then use a different browser with incognito mode to reliably see the new stuff.

cschnell · 2022-11-09T10:34:15Z

I tested the bugfix on my local system - unfortunately it did not solve the problem for me. @cschnell is your problem fixed?

sorry for my late reply. As this seems to only affect my editors (I can't reproduce, I can only see the result), I have to wait until they report back to me. So far, none has.

cschnell · 2022-11-10T07:14:41Z

Today, I had the possibility to check:
The bugfix of @jpmschuler works half. In the frontend, the image is processed and rendered, as it should. In the RTE however, the image is not shown, because the source is something like
<img alt="" data-alt-override="true" data-htmlarea-file-table="sys_file" data-htmlarea-file-uid="16561" data-title-override="true" height="750" src="https://www.mydomain.com/typo3/image/process?token=149f699b330312ff519c0fa3af2b6dd99658cd4b&id=35214" title="" width="1000" />

jpmschuler · 2022-11-10T08:16:40Z

Interesting, I dug deeper into it:
https://www.mydomain.com/typo3/image/process?token=149f699b330312ff519c0fa3af2b6dd99658cd4b&id=35214
gives a 404, while with a not-encoded &
https://www.mydomain.com/typo3/image/process?token=149f699b330312ff519c0fa3af2b6dd99658cd4b&id=35214
redirects to a proper /fileadmin/_processed_/c/0/csm_RTEmagicC_.... and shows the image

This sounds like we need to call the url and get its redirect target instead of using the url as-is.
Or at least if+str_replace the ampersand.

sgalinski · 2023-02-07T15:40:26Z

I guess there is some debug code in the RTE processing class that prevents resolving the current newly added images. I always get process URLs instead of the fileadmin ones. The process URLs can not be processed outside of the backend context. So if anyone has this problem and wants fileadmin URLs back, just implement the following patch.

diff -urNw rte-ckeditor-image.old/Classes/Database/RteImagesDbHook.php rte-ckeditor-image/Classes/Database/RteImagesDbHook.php
--- rte-ckeditor-image.old/Classes/Database/RteImagesDbHook.php	2023-02-03 14:02:02.000000000 +0100
+++ rte-ckeditor-image/Classes/Database/RteImagesDbHook.php	2023-02-07 16:28:12.125681023 +0100
@@ -247,7 +247,7 @@
                         // An original image file uid is available
                         try {
                             $originalImageFile = $resourceFactory
-                                ->getFileObject((int) $attribArray['data-htmlarea-file-uid'] . '0');
+                                ->getFileObject((int) $attribArray['data-htmlarea-file-uid']);
                         } catch (FileDoesNotExistException $exception) {
                             if ($this->logger !== null) {
                                 // Log the fact the file could not be retrieved.

jpmschuler · 2023-02-10T12:11:26Z

probably fixed by #218 as #220 was a duplicate of that

comeleleu · 2023-04-26T15:47:26Z

I have the same issue using TYPO3 11.5.26 and rte_ckeditor_image v11.0.9.

I've fixed it by creating an XClass in my website extension:

return new JsonResponse([
    ...
    'processed' => [
        ...
        'url'    => $processedFile->getOriginalFile()->getPublicUrl(),
    ],
    ...
]);

MIchelHolz · 2023-05-05T11:48:59Z

same for TYPO3 11.5.26,
solved by manually setting the target redirect url in my custom sanitizer extension with curl in BackendOnSave hook

mohammed-bens · 2023-06-15T07:25:43Z

same for TYPO3 11.5.26, solved by manually setting the target redirect url in my custom sanitizer extension with curl in BackendOnSave hook

Hello MichelHolz;
Can you tell us how you solved the problem?

stephangrass · 2023-06-16T15:08:14Z

I am also unable to get it working after updating to TYPO3 11. The images are being output with a URL like 'typo3/image/process?token=324234234'. rte_ckeditor_image in version 11.0.8 is installed ...

bigahuna · 2023-06-16T18:35:29Z

I am also unable to get it working after updating to TYPO3 11. The images are being output with a URL like 'typo3/image/process?token=324234234'. rte_ckeditor_image in version 11.0.8 is installed ...

Try including the extension in the template.

stephangrass · 2023-06-16T20:25:33Z

@bigahuna Including the extension in the template?

bigahuna · 2023-06-17T08:57:11Z

Edit the template for the site and add the "CKEditor Image Support" item to the "Selected Items" list.

stephangrass · 2023-06-19T05:33:58Z

@bigahuna The static template is included. That's not the problem ...

franhida · 2023-06-28T14:15:27Z

@bigahuna The static template is included. That's not the problem ...

Hi. I found out that adding the template actually makes a difference because it activates "Netresearch\RteCKEditorImage\Controller\ImageRenderingController" which preproess the image link and in case it has a "/typo3/image/process"-like URL.

However, as you posted, it will not suffice. You will have to add the following code in your extension package (or an extension that loads the TypoScript after rte_ckeditor_image's TypoScript):

lib.parseFunc_RTE.tags.img < lib.parseFunc.tags.img

This line will enable the rendering of the image in the Frontend.

Cheers.

Patta · 2023-06-28T20:21:13Z

If you use fluid_styled_content, include the ckeditor_image static template/setup before FSC. Or copy lib.parseFunc to lib.parseFunc_RTE

Gitsko · 2023-11-14T15:08:20Z

@navaki, @stephangrass is the problem solved for you with the above solutions or are there still problems? Does the problem still exist?

stephangrass · 2023-11-14T15:29:58Z

@navaki, @stephangrass is the problem solved for you with the above solutions or are there still problems? Does the problem still exist?

I think so ...

arunspt · 2023-11-22T12:34:02Z

Hi All,

Do we've any permanent solution for this issue? Sometimes it works and it returns URLS with /fileadmin and sometimes like "typo3/image/process?token=". The "typo3/image/process?token=" code returns broken images in the frontend and backend. I have this issue for both admin and editor users.

Any updates would be really appreciated.

Thank you.

muelli1000 · 2024-03-18T16:17:23Z

Hi All,

in Typo3 11.5.36 this issue still exist. Is there a solution? I have included the static Template before the fsc. Some Images in the RTE are still like https://www.domain.com/typo3/image/process?token=2fe79893bacb46f9710caacc82f7fb2c952d985b&id=145439

Does have anybody any ideas?

Thank you.

Gitsko · 2024-05-23T15:11:44Z

Hi @muelli1000,

Is the problem still there? Unfortunately I can't reproduce it, the images are output correctly for me, with and without adding static templates.

<img alt="" data-alt-override="true" data-htmlarea-file-table="sys_file" data-htmlarea-file-uid="166" data-title-override="true" src="/fileadmin/_processed_/6/d/csm_picard_s1_brd_front_stlbk-pc-games6_2625a161fb.jpg" style="" title="" width="100" height="56">

jpmschuler mentioned this issue Oct 29, 2022

[BUGFIX] fix misuse of 11LTS BE processing middleware URLs #194

Merged

CybotTM closed this as completed in #194 Nov 2, 2022

CybotTM reopened this Nov 14, 2022

dontWatchMeCode mentioned this issue Nov 25, 2022

compressed images not being created after update (10.1 ⇒ 11.0) #199

Closed

magicsunday added php PHP related task TYPO3 v11 labels Jan 21, 2023

jpmschuler added a commit to jpmschuler/t3x-rte_ckeditor_image that referenced this issue Feb 7, 2023

[TASK] add fix from netresearch#187 for images are not processed

7ef8804

jpmschuler mentioned this issue Feb 7, 2023

[TASK] add fix from #187 for images are not processed #220

Closed

MIchelHolz mentioned this issue Jun 17, 2023

bugfix: incorrect parse indexes leading to dynamic image URL not to b… #236

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

images are not processed #187

images are not processed #187

navaki commented Sep 5, 2022 •

edited

Loading

cschnell commented Sep 6, 2022 •

edited

Loading

navaki commented Sep 19, 2022 •

edited

Loading

jpmschuler commented Oct 28, 2022

jpmschuler commented Oct 29, 2022

cschnell commented Oct 31, 2022

navaki commented Nov 8, 2022 •

edited

Loading

jpmschuler commented Nov 8, 2022

cschnell commented Nov 9, 2022

cschnell commented Nov 10, 2022

jpmschuler commented Nov 10, 2022

sgalinski commented Feb 7, 2023 •

edited

Loading

jpmschuler commented Feb 10, 2023

comeleleu commented Apr 26, 2023 •

edited

Loading

MIchelHolz commented May 5, 2023 •

edited

Loading

mohammed-bens commented Jun 15, 2023

stephangrass commented Jun 16, 2023

bigahuna commented Jun 16, 2023

stephangrass commented Jun 16, 2023

bigahuna commented Jun 17, 2023

stephangrass commented Jun 19, 2023

franhida commented Jun 28, 2023 •

edited

Loading

Patta commented Jun 28, 2023 •

edited

Loading

Gitsko commented Nov 14, 2023

stephangrass commented Nov 14, 2023

arunspt commented Nov 22, 2023

muelli1000 commented Mar 18, 2024

Gitsko commented May 23, 2024

images are not processed #187

images are not processed #187

Comments

navaki commented Sep 5, 2022 • edited Loading

cschnell commented Sep 6, 2022 • edited Loading

navaki commented Sep 19, 2022 • edited Loading

jpmschuler commented Oct 28, 2022

jpmschuler commented Oct 29, 2022

cschnell commented Oct 31, 2022

navaki commented Nov 8, 2022 • edited Loading

jpmschuler commented Nov 8, 2022

cschnell commented Nov 9, 2022

cschnell commented Nov 10, 2022

jpmschuler commented Nov 10, 2022

sgalinski commented Feb 7, 2023 • edited Loading

jpmschuler commented Feb 10, 2023

comeleleu commented Apr 26, 2023 • edited Loading

MIchelHolz commented May 5, 2023 • edited Loading

mohammed-bens commented Jun 15, 2023

stephangrass commented Jun 16, 2023

bigahuna commented Jun 16, 2023

stephangrass commented Jun 16, 2023

bigahuna commented Jun 17, 2023

stephangrass commented Jun 19, 2023

franhida commented Jun 28, 2023 • edited Loading

Patta commented Jun 28, 2023 • edited Loading

Gitsko commented Nov 14, 2023

stephangrass commented Nov 14, 2023

arunspt commented Nov 22, 2023

muelli1000 commented Mar 18, 2024

Gitsko commented May 23, 2024

navaki commented Sep 5, 2022 •

edited

Loading

cschnell commented Sep 6, 2022 •

edited

Loading

navaki commented Sep 19, 2022 •

edited

Loading

navaki commented Nov 8, 2022 •

edited

Loading

sgalinski commented Feb 7, 2023 •

edited

Loading

comeleleu commented Apr 26, 2023 •

edited

Loading

MIchelHolz commented May 5, 2023 •

edited

Loading

franhida commented Jun 28, 2023 •

edited

Loading

Patta commented Jun 28, 2023 •

edited

Loading