-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(providers): conform Apple #12068
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12068 +/- ##
==========================================
- Coverage 39.27% 39.21% -0.06%
==========================================
Files 191 191
Lines 29852 29920 +68
Branches 1288 1297 +9
==========================================
+ Hits 11725 11734 +9
- Misses 18127 18186 +59 ☔ View full report in Codecov by Sentry. |
Authjs (next-auth) 5.0.0-beta.25 worked for me for Apple login today, even after upgrading to Next 15.0/React 19.0. Many thanks for your efforts on this. |
thanx, your hint was helpful, I upgraded from v5.22 to v5.25 and it worked |
Good to hear! Thanks for letting me know.
… On Jan 10, 2025, at 4:38 AM, Ahmed ElWafy ***@***.***> wrote:
Authjs (next-auth) 5.0.0-beta.25 worked for me for Apple login today, even after upgrading to Next 15.0/React 19.0. Many thanks for your efforts on this.
thanx, your hint was helpful, I upgraded from v5.22 to v5.25 and it worked
—
Reply to this email directly, view it on GitHub <#12068 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKZN4O2ZTWT5WCLRLLOSOL2J6IITAVCNFSM6AAAAABQHYJ46GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBSGE4TINZTGA>.
You are receiving this because you commented.
|
☕️ Reasoning
"Sign in with Apple" is not the smoothest thing to implement. The DX for setting things up for development is subpar considering the UX they uphold themselves for their users. It requires extra hops on every corner.
But here it is. With some hacks in the core library - since Apple is unable to follow the OIDC spec -, it is now fully working again. I'm sorry for those who needed to implement hacks for it before.
As part of this work, we've also worked on a way to generate the client secret with a community member, since Apple expects it to be a JWT. You can run
npx auth add apple
in the root of your project, and it will give you a step-by-step on how to do it. At the end, it will add theAUTH_APPLE_ID
andAUTH_APPLE_SECRET
to your env file as well.Feedback on it is appreciated!
Huge thanks to @ChrGrb for the preliminary work in #8428 and #8189.
🧢 Checklist
🎫 Affected issues
Closes #8189
Closes #6788
Closes #4061
Closes #8188
Closes #9989
📌 Resources