Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version parsing regex can't parse some valid version #164

Open
fabianegli opened this issue Oct 6, 2021 · 2 comments
Open

Version parsing regex can't parse some valid version #164

fabianegli opened this issue Oct 6, 2021 · 2 comments

Comments

@fabianegli
Copy link

fabianegli commented Oct 6, 2021

openms_version_regex = r"([0-9][.][0-9][.][0-9])"

The above regex r"([0-9][.][0-9][.][0-9])" doesn't match the historic openMS version 1.11.0. I think the regex should be either expanded to allow multi digit main, minor and bug release versions or maybe even be expanded to match all Semantic Versioning 2.0.0, if that is indeed what openMS (and the other tools) adheres to. The SemVer website contains regexes with and without named groups: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string

@fabianegli
Copy link
Author

... and the regexes got ditched for this job. See the current scrape_software_versions.py and this PR diff.

@jpfeuffer
Copy link
Collaborator

I think version parsing probably just moved to each module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants