Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Dockerfile for data plane #376

Closed
kate-osborn opened this issue Jan 17, 2023 · 2 comments
Closed

Write Dockerfile for data plane #376

kate-osborn opened this issue Jan 17, 2023 · 2 comments
Assignees

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Jan 17, 2023

Parent issue: #292

Write a Dockerfile for the data plane. Consider the following questions when writing:

Will the agent be PID 1 that will also start NGINX?
What will happen if NGINX master fails (terminates) ? What will happen if the agent fails?
How to gracefully shutdown NGINX?

A/C:

  • The container runs both nginx and agent processes
  • The container is as small as possible
  • Add build step to Makefile

Aha! Link: https://nginx.aha.io/features/NKG-34

@pleshakov
Copy link
Contributor

do we need to do anything with CI (like building/publishing new images) ?

@brianehlert
Copy link

do we need to do anything with CI (like building/publishing new images) ?

We should, but we can tie that to some release preparation later on.
For now, consider the NIC pattern here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants