-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time to drop WinPcap supprt and have NPCAP dlls in C:\WINDOWS\system32\ #754
Comments
The only WinPcap-related code in Npcap is, as far as I know, the installation of Npcap's wpcap.dll and packet.dll in C:\Windows\System32\Npcap, with an on-by-default option to install them in C:\Windows\System32 as well. Presumably the choice not to install them there is offered in case some old program built with WinPcap is installed and might break if run with Npcap's versions. The old AirPcap support in packet.dll is still in Npcap, in addition to the pcap-airpcap.c file in libpcap (which I did test, ages ago, with an AirPcap NX adapter, on one of my Windows VMs). It appears that the TurboCap code in libpcap came from WinPcap, and was implemented as a pcap-tc.c module; I pulled that into libpcap back in 2015. So that one's a libpcap issue, not an Npcap issue, unless Npcap needs to offer it. The hardware was EOLed over 10 years ago, and the last software release was over 14 years ago. |
Npcap defaults to installing its DLLs into
Note that since Npcap 0.9986, Nmap will install into System32 even if a previous Npcap install did not, making |
The remaining changes that could be made to address this issue are:
If we renamed the option, we would likely not change the command-line option name, so that existing deployment scripts would not need to be updated. |
I'm almost sure I did a default installation of wireshark and ended up with the dlls in SYSTEMROOT%\System32\npcap\ |
A copy of the DLLs is always installed in %SYSTEMROOT%\System32\npcap. The option controls whether another copy is installed in %SYSTEMROOT%\System32\ |
C:\Windows\System32>dir wpcap* Directory of C:\Windows\System32 2024-05-27 17:09 344 064 WpcApi.dll C:\Windows\System32>cd Npcap C:\Windows\System32\Npcap>dir Directory of C:\Windows\System32\Npcap 2024-09-24 18:23 .2024-10-14 22:23 .. 2024-01-18 23:15 156 544 NpcapHelper.exe 2024-01-18 23:14 220 032 Packet.dll 2024-01-18 23:15 266 624 WlanHelper.exe 2024-01-18 23:15 491 392 wpcap.dll 4 File(s) 1 134 592 bytes 2 Dir(s) 181 667 393 536 bytes free |
@AndersBroman Please provide the output of DiagReport and your installation logs as described in the Npcap Guide. This will show what installation options were used and what files are present or missing in your installation. |
Hi,
I recently stumbled across the-tcpdump-group/libpcap#1368
At the very least I think it's time to have NPCAP as the default in the dll path and possibly get rid of all code related to
WinPcap, AirPcap and TurboPcap. WinPcap has not been supported for many years, AirPcap HW is no longer manufactured and I'm not sure how useful it would be with modern WiFi standards. I would guess turbopcap is outdated by now as well...
So geting rid of all that outdated code would make sense I think.
The text was updated successfully, but these errors were encountered: