Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: punycode alternative name collision #35744

Closed
1 task done
whymarrh opened this issue Oct 21, 2020 · 2 comments
Closed
1 task done

doc: punycode alternative name collision #35744

whymarrh opened this issue Oct 21, 2020 · 2 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@whymarrh
Copy link

📗 API Reference Docs Problem

  • Version: v12.19.0 LTS
  • Platform: Darwin x86_64
  • Subsystem: punycode

Location

Section of the site where the content exists

Affected URL(s):

Description

Concise explanation of the problem

The punycode module docs note that it is deprecated and suggest using Punycode.js as an alternative:

The version of the punycode module bundled in Node.js is being deprecated.
In a future major version of Node.js this module will be removed. Users
currently depending on the punycode module should switch to using the
userland-provided Punycode.js module instead.

[…]

The punycode module is a third-party dependency used by Node.js and
made available to developers as a convenience. Fixes or other modifications to
the module must be directed to the Punycode.js project.

The alternative suggested is published as punycode on npm and thus its name is shadowed by the bundled version. A workaround is required to use the third-party module in place of the bundled module (see mathiasbynens/punycode.js#79 and mathiasbynens/punycode.js#113).

The API docs should either document the workaround required to use the suggested alternative, not suggest an alternative, or suggest an alternative that doesn't require a workaround.


  • I would like to work on this issue and
    submit a pull request.
@whymarrh whymarrh added the doc Issues and PRs related to the documentations. label Oct 21, 2020
@jasnell
Copy link
Member

jasnell commented Apr 27, 2021

The Punycode.js project readme already includes a good documentation notice about the workaround. I'm not convinced there's anything we really should do here.

@jasnell
Copy link
Member

jasnell commented May 12, 2021

Closing given the above. We can reopen if there's more to discuss

@jasnell jasnell closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

No branches or pull requests

2 participants