-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DigiD Machtigen and eHerkenning bewindveoering with OIDC #1471
Labels
Comments
2 tasks
SilviaAmAm
added a commit
that referenced
this issue
Mar 31, 2022
SilviaAmAm
added a commit
that referenced
this issue
Mar 31, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 6, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 6, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 13, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 19, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 19, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 19, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 19, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 19, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 19, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
SilviaAmAm
added a commit
that referenced
this issue
Apr 26, 2022
sergei-maertens
added a commit
that referenced
this issue
Apr 28, 2022
…voering [#1471] eHerkenning bewindvoering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, when logging in with DigiD, the
OIDCAuthenticationRequestView
from themozilla_django_oidc
library redirects to the URL where the user needs to log in. Once they have logged in, they are redirected toOIDCAuthenticationCallbackView
.In the
mozilla_django_oidc
, a new user would be created and logged in. We overwrite the backend https://github.com/open-formulieren/open-forms/blob/master/src/digid_eherkenning_oidc_generics/backends.py#L29 so thatget_or_create_user
always returns anAnonymousUser
. Before the user is created, the claims are extracted from the response and put into the session (https://github.com/open-formulieren/open-forms/blob/master/src/digid_eherkenning_oidc_generics/backends.py#L26). Currently only the value of theidentifier_claim_name
attribute is added to the session (with keydigid_oidc:bsn
for digid,eherkenning_oidc:kvk
for eHerkenning).Atm, the value of the
identifier_claim_name
is configured through the admin.For DigiD machtigen, the backend needs to extract the following nested attributes:
aanvrager.bsn
gemachtigde.bsn
For eHerkenning:
aanvrager.kvk
gemachtigde.pseudoID
aanvrager.pseudoID
?Edit:
Discussed this with Maarten. For now keycloak only sends
aanvrager.kvk
andgemachtigde.bsn
. PseudoIDs are not used yet and theaanvrager.bsn
is not sent. PseudoIDs are apparently encrypted versions of the BSN sent by DigiD or eHerkenning.These need to be put in the session so that the
digid_eherkenning_oidc
plugin can add them to theform_auth
(https://github.com/open-formulieren/open-forms/blob/master/src/openforms/authentication/contrib/digid_eherkenning_oidc/plugin.py#L73).The attribute/value will be filled with the aanvrager.bsn/kvk while the bsn/pseudoID of the gemachtigde will be in a separate key
gemachtigde
on the form_auth dict.When a session is started, now there is a signal that fills the auth fields on the submission based on what is in the session.
https://github.com/open-formulieren/open-forms/blob/master/src/openforms/authentication/signals.py#L64
Prefills
The prefills should be able to fill the form with the data of both persons involved (vertegenwoordigde and gemachtigde).
The text was updated successfully, but these errors were encountered: