Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Feature: Loading skeleton in Hero #297

Closed
2 tasks done
NsdHSO opened this issue Aug 8, 2022 · 6 comments
Closed
2 tasks done

Feature: Loading skeleton in Hero #297

NsdHSO opened this issue Aug 8, 2022 · 6 comments

Comments

@NsdHSO
Copy link
Contributor

NsdHSO commented Aug 8, 2022

Type of feature

🍕 Feature

Current behavior

If you search in the search box after one repo, we receive responses 1-2 seconds. I think we should display a skeleton

Suggested solution

     if (isLoading) {
    return (
      <div className="p-4 border rounded-2xl bg-white w-full space-y-1 relative">
       // Hint Array.from(Array(5)) || props count = {1,2,3....}
        <Skeleton
          enableAnimation
          count={1}
        />
      </div>
    );
  }

Additional context

issue:
fix #297

PR:
#296

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@NsdHSO NsdHSO changed the title Feature: Loading skeleton Feature: Loading skeleton in Hero Aug 8, 2022
@bdougie
Copy link
Member

bdougie commented Aug 8, 2022

not technically a good first issue since it is blocked by another PR. All Good First Issues should have clear solutions.

@bdougie bdougie removed the good first issue Good for newcomers label Aug 8, 2022
@OgDev-01
Copy link
Contributor

.take

@github-actions
Copy link

Thanks for taking this on! If you have not already, join the conversation in our Discord

@OgDev-01
Copy link
Contributor

I'm thinking about making the hero card a separate reusable component, to stay organized... @bdougie what do u think about that?

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Aug 12, 2022

Yes, good remarks, but you don't have this to do with this issue. See here, we get the answer after 1-2 seconds.
image

@bdougie
Copy link
Member

bdougie commented Oct 4, 2022

Closing this for now. however, we do need a skeleton for RepoWrap instead. I will open that issue.

@bdougie bdougie closed this as completed Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants