[exporter/clickhouse] Fix Nil Pointer Exception on Metrics/Traces export without service.name Resource Attribute #37034
+94
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort without service.name Resource Attribute
JaredTan95
reviewed
Jan 7, 2025
| @@ -109,7 +109,10 @@ func (g *gaugeMetrics) insert(ctx context.Context, db *sql.DB) error { | |||
| }() | |||
|
|
|||
| for _, model := range g.gaugeModels { | |||
| serviceName, _ := model.metadata.ResAttr.Get(conventions.AttributeServiceName) | |||
| var serviceName string | |||
| if v, ok := model.metadata.ResAttr.Get(conventions.AttributeServiceName); ok { | |||
There was a problem hiding this comment.
I prefer it as a helper function
There was a problem hiding this comment.
Good idea!
I've a made a helper function for it and also put some tests for this new function.
As a bonus - made some small optimizations on metrics export
Small optimizations on metrics export
SpencerTorres
approved these changes
Jan 7, 2025
JaredTan95
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing Nil Pointer Exception regression introduced in #35725
Link to tracking issue
Fixes #37030
Testing
Unit test adjusted to include test Metric without
service.nameResource AttributesDocumentation