Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for reading resource-related fields from span attributes #37077

Open
IbraheemA opened this issue Jan 7, 2025 · 3 comments
Open
Labels
connector/datadog enhancement New feature or request

Comments

@IbraheemA
Copy link
Contributor

IbraheemA commented Jan 7, 2025

Component(s)

connector/datadog

Describe the issue you're reporting

When transforming an OTLP span to a Datadog span (in either datadogconnector or datadogexporter), the following attributes are read from the OTLP span and used to populate the fields of the Datadog span:

  • datadog.host.name,
  • container.id
  • k8s.pod.id
  • deployment.environment.name
  • service.name
  • service.version

We would like these to be read from resource attributes and only resource attributes. In previous releases, some of these attributes could be set in span attributes as well - however, we are in the process of deprecating that, to match Datadog's specification. This issue is to flag this change and track the deprecation effort.

Tracking work:

We've merged a few PRs to introduce an alternative code path in the Datadog trace agent (which performs trace translation) that deprecates this functionality: see DataDog/datadog-agent#30981

This PR deprecates the functionality for when connector.datadogconnector.NativeIngest is enabled. This user who was using service.name in span attributes encountered an issue following this change..

In a future PR, we'll add a feature flag which allows users to enable the alternate code path when connector.datadogconnector.NativeIngest is disabled as well.

@IbraheemA IbraheemA added the needs triage New item requiring triage label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label Jan 8, 2025
@JaredTan95
Copy link
Member

I think #36924 might be a related issue?

@mx-psi mx-psi added the enhancement New feature or request label Jan 8, 2025
@IbraheemA
Copy link
Contributor Author

I think #36924 might be a related issue?

That issue is concerning the datadogreceiver, which has its own translation logic separate of the one used in the exporter and connector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/datadog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants