Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Enforce that components from any distribution listed in cmd/otelcontribcol/builder-config.yaml #37087

Open
dmitryax opened this issue Jan 8, 2025 · 0 comments · May be fixed by open-telemetry/opentelemetry-collector-releases#794
Open

[CI] Enforce that components from any distribution listed in cmd/otelcontribcol/builder-config.yaml #37087

dmitryax opened this issue Jan 8, 2025 · 0 comments · May be fixed by open-telemetry/opentelemetry-collector-releases#794
Assignees
@dmitryax
Labels
bug Something isn't working ci-cd CI, CD, testing, build issues release:blocker The issue must be resolved before cutting the next release release-retro Issues discussed in a release retrospective

Comments

@dmitryax
Copy link
Member

dmitryax commented Jan 8, 2025 •
edited
Loading

We recently added a new component to k8s and contrib distributions in the releases repo: open-telemetry/opentelemetry-collector-releases#789.

The collector was never built with this component because it wasn't added to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/otelcontribcol/builder-config.yaml that is used by the built-and-test CI jobs. Hence, the component was only built when the new collector version was to be released and failed: https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/12664303446/job/35292225799?pr=791

We need to enforce that a component is listed in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/otelcontribcol/builder-config.yaml before it can be added to any distribution.
@dmitryax dmitryax added bug Something isn't working needs triage New item requiring triage release:blocker The issue must be resolved before cutting the next release ci-cd CI, CD, testing, build issues and removed bug Something isn't working needs triage New item requiring triage labels Jan 8, 2025
@dmitryax dmitryax mentioned this issue Jan 8, 2025
Merged
@dmitryax dmitryax self-assigned this Jan 8, 2025
@TylerHelmuth TylerHelmuth added the release-retro Issues discussed in a release retrospective label Jan 8, 2025
@dmitryax dmitryax linked a pull request Jan 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitryax dmitryax

Labels
bug Something isn't working ci-cd CI, CD, testing, build issues release:blocker The issue must be resolved before cutting the next release release-retro Issues discussed in a release retrospective
Projects
None yet
Milestone
No milestone
2 participants
@dmitryax @TylerHelmuth