Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Is it meaningless code? [File: stream.cc] #615

Open
yy-tayu opened this issue Nov 21, 2022 · 0 comments
Open

Is it meaningless code? [File: stream.cc] #615

yy-tayu opened this issue Nov 21, 2022 · 0 comments

Comments

@yy-tayu
Copy link

yy-tayu commented Nov 21, 2022

Hi,
In the file stream.cc, I found several strange codes as follows:

LocalStream::LocalStream(const LocalCameraStreamParameters& parameters,
                         int& error_code) {
    //do something...
    **rtc::scoped_refptr<webrtc::VideoCaptureModule> capturer(nullptr);**
    //do something...
}

LocalStream::LocalStream(
    std::shared_ptr<LocalDesktopStreamParameters> parameters,
    std::unique_ptr<LocalScreenStreamObserver> observer) {
    //do something...
    **std::unique_ptr<BasicDesktopCapturer> capturer(nullptr);**
    //do something...
}

LocalStream::LocalStream(
    std::shared_ptr<LocalCustomizedStreamParameters> parameters,
    std::unique_ptr<VideoFrameGeneratorInterface> framer) {
    //do something...
  **std::unique_ptr<CustomizedFramesCapturer> capturer(nullptr);**
    //do something...
}

LocalStream::LocalStream(
    std::shared_ptr<LocalCustomizedStreamParameters> parameters,
    VideoEncoderInterface* encoder) {
    //do something...
    **std::unique_ptr<CustomizedFramesCapturer> capturer(nullptr);**
    //do something...
}

Why?
Thanks in advance!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant