From 4f1458ef76e7f00798c860c22ab23c04ee2eeca2 Mon Sep 17 00:00:00 2001 From: Nathaniel Flath Date: Wed, 10 Jul 2024 14:26:35 -0700 Subject: [PATCH 1/2] Enhance specification for AFTresults for unviable NextHops --- doc/specification.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/specification.md b/doc/specification.md index c104c78..5d7c639 100644 --- a/doc/specification.md +++ b/doc/specification.md @@ -288,6 +288,8 @@ An `AFTResult` message MUST have the following fields populated by the device: * `FAILED` - indicates that the AFT operation can not be programmed into the RIB (e.g. missing reference, invalid content, semantic errors, etc). * Available in all acknowledge modes. + * A unviable but valid next-hop should not cause a FAILED status. For + example, next-hop that encaps to a unresolvable prefix should not fail. * `RIB_PROGRAMMED` - indicates that the AFT operation was successfully programmed into the RIB. * Available in all acknowledge modes. @@ -301,6 +303,7 @@ An `AFTResult` message MUST have the following fields populated by the device: * Only available in the `RIB_AND_FIB_ACK` acknowledge mode. * Implies that the AFT operation was also successfully programmed into the RIB. + * Returned for unviable but valid next-hops and operations using them. * `FIB_FAILED` - indicates that the AFT operation was meant to be programmed into the FIB but the device failed to do it. * `timestamp` - records the time at which the gRIBI daemon received and From 37f1655b5c0b28a366d93bcfcca4f10dcbf440bb Mon Sep 17 00:00:00 2001 From: Nathaniel Flath Date: Fri, 12 Jul 2024 14:11:02 -0700 Subject: [PATCH 2/2] Review comments --- doc/specification.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/specification.md b/doc/specification.md index 5d7c639..7f457c6 100644 --- a/doc/specification.md +++ b/doc/specification.md @@ -303,7 +303,8 @@ An `AFTResult` message MUST have the following fields populated by the device: * Only available in the `RIB_AND_FIB_ACK` acknowledge mode. * Implies that the AFT operation was also successfully programmed into the RIB. - * Returned for unviable but valid next-hops and operations using them. + * Returned for unviable but valid next-hops and operations using them - + these are allowed to blackhole. * `FIB_FAILED` - indicates that the AFT operation was meant to be programmed into the FIB but the device failed to do it. * `timestamp` - records the time at which the gRIBI daemon received and