Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Segment Routing (SR) for OSPFv2 #1055

Open
jardel-lucca-venko opened this issue Feb 21, 2024 · 2 comments
Open

Enabling Segment Routing (SR) for OSPFv2 #1055

jardel-lucca-venko opened this issue Feb 21, 2024 · 2 comments

Comments

@jardel-lucca-venko
Copy link

Hi,

We can enable SR for IS-IS with:

.../network-instance/protocols/protocol/isis/global/segment-routing/config/enabled

This segment-routing container is defined in openconfig-segment-routing.yang ("oc-sr") sr-igp-top grouping.

It was added in commit 55573d7 (openconfig-isis.yang):

   grouping isis-global-base {
     description
       "This grouping describes ISIS Global router.";

     ...
+
+    uses oc-sr:sr-igp-top;
   }

However, it would be useful to have this for OSPFv2 as well.

I believe we could similarly include sr-igp-top in .../protocol/ospfv2/global container (openconfig-ospfv2-global.yang):

   grouping ospfv2-global-structural {
     description
       "Top level structural grouping for OSPFv2 global parameters";
             
     container global {
       description
         "Configuration and operational state parameters for settings
         that are global to the OSPFv2 instance";
               
       ...
+
+      uses oc-sr:sr-igp-top;
     }     
   }

Would such inclusion be acceptable?

Thanks.
Jardel Lucca

Copy link

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 20, 2024
@dplore
Copy link
Member

dplore commented Aug 21, 2024

Hi @jardel-lucca-venko, if you intend to use ospf with segment routing and are willing to create a PR with the yang model, find the implementation references confirming the support and a good reviewer with some OSPF/SR experience we would welcome the contribution!

I am not familiar with OSPF support for SR to know if your proposal is valid, but from a distance it sounds like a good approach. If you can provide sufficiently detailed implementation references/documentation I think you could demonstrate in a PR that what's being added is in fact supported by at least 2 implementations. Then the review has a good chance of going smoothly.

@github-actions github-actions bot removed the Stale label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants