Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-type of set-community/config/options should be leaf-list #1136

Open
Taapasee opened this issue Jun 20, 2024 · 2 comments
Open

node-type of set-community/config/options should be leaf-list #1136

Taapasee opened this issue Jun 20, 2024 · 2 comments

Comments

@Taapasee
Copy link

When the following node is a leaf-list
/routing-policy/policy-definitions/policy-definition/statements/statement/actions/bgp-actions/set-community/reference/config/community-set-refs
The following should also be made a leaf-list, and the count should match in both.
/routing-policy/policy-definitions/policy-definition/statements/statement/actions/bgp-actions/set-community/config/options

Similarly for the ext-community.
/routing-policy/policy-definitions/policy-definition/statements/statement/actions/bgp-actions/set-ext-community/reference/config/ext-community-set-refs being a leaf-list implies
/routing-policy/policy-definitions/policy-definition/statements/statement/actions/bgp-actions/set-ext-community/config/options
should be made a leaf-list with matching count.

Copy link

This issue is stale because it has been open 180 days with no activity. If you wish to keep this issue active, please remove the stale label or add a comment, otherwise will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 18, 2024
@dplore
Copy link
Member

dplore commented Dec 18, 2024

Hi, thanks for the comment.

If multiple options are desired (add, remove, replace) It seems it's possible to have one statement for the add and a separate statement for the delete. This is perhaps a bit more verbose that what you are suggesting.

Do we think we need the complexity of having a list of add,delete,replace to align with a list of community-set-refs? Can you make a concrete use case why this is much better?

@github-actions github-actions bot removed the Stale label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants