From 7a7b21d66740660890eaa9abc862a7e73280c885 Mon Sep 17 00:00:00 2001 From: Rob Shakir Date: Mon, 6 Nov 2023 17:35:21 -0800 Subject: [PATCH] Add TODO. --- protomap/proto.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/protomap/proto.go b/protomap/proto.go index 25d62fac..def7db99 100644 --- a/protomap/proto.go +++ b/protomap/proto.go @@ -955,6 +955,9 @@ func makeWrapper(msg protoreflect.Message, fd protoreflect.FieldDescriptor, val wasTypedVal = true } + // TODO(robjs): Support wpb.IntValue and wpb.BoolValue and add corresponding + // tests. + newV := msg.NewField(fd) switch newV.Message().Interface().(type) { case *wpb.StringValue: @@ -975,7 +978,6 @@ func makeWrapper(msg protoreflect.Message, fd protoreflect.FieldDescriptor, val } nsv = uint64(iv) } - return (&wpb.UintValue{Value: nsv}).ProtoReflect(), true, nil case *wpb.BytesValue: bv, ok := val.([]byte)