Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe merge of client_metadata and trust chain final metadata #20

Open
peppelinux opened this issue Sep 4, 2024 · 2 comments
Open

Safe merge of client_metadata and trust chain final metadata #20

peppelinux opened this issue Sep 4, 2024 · 2 comments
Assignees

Comments

@peppelinux
Copy link
Member

Discussion in OpenID4VP here: https://github.com/openid/OpenID4VP/pull/233/files#r1744565264

there might be cases where the Credential Verifier uses ephemeral metadata parameters, such as jwks for encryption, within the client_metadata parameter used in the request. For this reason the client_metadata parameter has sense to be kept and therefore must be handled safely

@TomCJones
Copy link

what's the question?

@jogu
Copy link

jogu commented Dec 3, 2024

FWIW https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-5.1 currently says:

Authoritative data the Wallet is able to obtain about the Client from other sources, for example those from an OpenID Federation Entity Statement, take precedence over the values passed in client_metadata.

I think further clarification is needed somewhere about behaviour here. But my assumption is that the verifier would not publish an encryption key in its jwks published via Federation, and hence it would be compliant with the above spec to take an encryption key from client_metadata instead (as the Verifier wouldn't have an authoritative encryption key).

@peppelinux peppelinux moved this to Todo in Federation Wallet Jan 15, 2025
@peppelinux peppelinux moved this from Todo to In Progress in Federation Wallet Jan 15, 2025
@peppelinux peppelinux self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants