Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textmetrics: Release ready #5516

Open
2 of 5 tasks
kintel opened this issue Dec 22, 2024 · 7 comments
Open
2 of 5 tasks

textmetrics: Release ready #5516

kintel opened this issue Dec 22, 2024 · 7 comments

Comments

@kintel
Copy link
Member

kintel commented Dec 22, 2024

Make textmetrics() release ready:

  • Final API validation
  • Move out of experimental
  • Validate test coverage
  • Manual entry
  • Cheat sheet entry

Main release checklist: #3640

@jordanbrown0
Copy link
Contributor

jordanbrown0 commented Dec 30, 2024

  • API validation: somebody else needs to do that. I was happy with it when I PRed it, or I wouldn't have.
  • Test coverage: I did include a few tests (tests/data/scad/2D/features/text-metrics.scad, tests/data/scad/misc/text-metrics-test.scad). Looking at them now, they could be a bit more comprehensive:
    • With and without descenders.
    • With and without characters that go above the midline.
    • Characters where the lowest point is above the baseline. (I think these currently behave strangely with valign=bottom.)
    • All 4x3 alignment types.
    • RTL, LTR, TTB, BTT. (But TTB and BTT are known to have suboptimal alignment behaviors.)
  • Manual: how do we do development-snapshot manual work? Just mark as "require development snapshot"?
  • Cheat sheet: where is it? PR to openscad/openscad.github.com?

I can work on tests and docs.

@kintel
Copy link
Member Author

kintel commented Dec 30, 2024

  • Manual: how do we do development-snapshot manual work? Just mark as "require development snapshot"?

We've been using {{requires|Development snapshot}} - see e.g. https://en.wikibooks.org/w/index.php?title=OpenSCAD_User_Manual/User-Defined_Functions_and_Modules&diff=prev&oldid=3806773

@kintel
Copy link
Member Author

kintel commented Dec 30, 2024

  • Cheat sheet: where is it? PR to openscad/openscad.github.com?

Yes, we have one for the latest release, and one for the snapshot:
https://github.com/openscad/openscad.github.com/tree/main/cheatsheet

@kintel
Copy link
Member Author

kintel commented Dec 30, 2024

  • API validation: somebody else needs to do that. I was happy with it when I PRed it, or I wouldn't have.

Yeah, agreed - just want to take a look with fresh eyes and try to break any corner cases :)

@jordanbrown0
Copy link
Contributor

Cheat sheet updates in PR#144.
Doc updates at
https://en.wikibooks.org/wiki/Special:Contributions/Jordan_Brown
31 December 2024, 01:33 through 05:13 UTC.

@jordanbrown0
Copy link
Contributor

Opinions on whether we need more tests?

@kintel
Copy link
Member Author

kintel commented Dec 31, 2024

Let's wait for the API validation. If I end up doing that, I might discover what I feel needs more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants