Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trustmanager initialization exception are logged and not propogated #522

Open
1 of 3 tasks
arvindn05 opened this issue Oct 8, 2017 · 0 comments
Open
1 of 3 tasks

Comments

@arvindn05
Copy link
Member

Description

As part of the X509TrustManagerFactory constructor, we are loading the trust manager and the trust store.

In case the trust store is not accessible or missing, we just log the error and don't propagate it out.

Need to look at this behavior for possible security issues

Expected Behavior

Propogate the exception and fail the startup/task as appropriate

Actual Behavior

Exception is logged and silenced

Steps to Reproduce

Run junit test for VSConformanceCheckMetaTaskTest

Additional Information

Environment

  • OSC Version/Build: 1.0.0-SNAPSHOT (Build:96-g448bc3a

Status

  • Reproduced
  • In Progress
  • Validated => Verified in Version/Build:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant