Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping CBS ids #510

Open
joepio opened this issue Jan 13, 2025 · 1 comment
Open

Consider dropping CBS ids #510

joepio opened this issue Jan 13, 2025 · 1 comment
Labels
bug High priority issue for (blocking) problems

Comments

@joepio
Copy link
Contributor

joepio commented Jan 13, 2025

We currently map every municipality to CBS and Allmanak identifiers. If I remember correctly, we did this because we pulled some data from these sources, like the logo of the organization.

Since we now pretty much exclusively focus on the Documents instead of other resources, I'm not quite sure if we're still using these mappings.

It would make the codebase and the sourcefiles a lot cleaner if we can deprecate these. It would also speed up the process of adding new municipalities.

@joepio joepio added the bug High priority issue for (blocking) problems label Jan 13, 2025
@joepio
Copy link
Contributor Author

joepio commented Jan 13, 2025

According to @robvandijk the allmanak is still used, but the CBS id doesn't seem to be.

@joepio joepio changed the title Consider dropping Allmanak & CBS ids Consider dropping CBS ids Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug High priority issue for (blocking) problems
Projects
None yet
Development

No branches or pull requests

1 participant