Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Windows #113

Open
j0hnm4r5 opened this issue Dec 3, 2023 · 4 comments
Open

Add support of Windows #113

j0hnm4r5 opened this issue Dec 3, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@j0hnm4r5
Copy link

j0hnm4r5 commented Dec 3, 2023

I do see that you call out in the README, but obviously including the binaries for Windows would be ideal.

I opened up an issue over at @openzim/libzim, since it seems like building libzim for Windows is a pain point.

@kelson42 kelson42 changed the title libzim binaries not installed for Windows Add support of Windows Dec 3, 2023
@kelson42
Copy link
Contributor

kelson42 commented Dec 3, 2023

@j0hnm4r5 Thank you for opening this ticket. I'm very supportive of this and actually wonders that we don't have open a ticket earlier. Probably because I already know that this ticket is blocked by kiwix/kiwix-build#466. But considering that kiwix/kiwix-build#466 is going to be fixed soon. This is a very good time to open it.

Assuming we have the properly DLL of libzim, do you think you could add the support of Windows to Node-libzim?

@kelson42 kelson42 added the task label Dec 3, 2023
@kelson42 kelson42 added this to the 3.2.0 milestone Dec 3, 2023
@kelson42
Copy link
Contributor

kelson42 commented Dec 3, 2023

Blocked by #118 too, but should be quick to fix

@j0hnm4r5
Copy link
Author

j0hnm4r5 commented Dec 3, 2023

Absolutely. I'll do everything I can.

@kelson42 kelson42 modified the milestones: 3.2.0, 3.3.0 Dec 9, 2023
@j0hnm4r5 j0hnm4r5 removed their assignment Jun 10, 2024
@kelson42 kelson42 self-assigned this Jun 25, 2024
@kelson42
Copy link
Contributor

@j0hnm4r5 We have now the libzimbinaries for Windows, see https://download.openzim.org/release/libzim/libzim_win-x86_64-9.2.3-2.zip. We should build the binding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants