Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch 'addArticle's #14

Open
ISNIT0 opened this issue May 21, 2019 · 4 comments
Open

Batch 'addArticle's #14

ISNIT0 opened this issue May 21, 2019 · 4 comments

Comments

@ISNIT0
Copy link
Contributor

ISNIT0 commented May 21, 2019

The majority of CPU time in CPP (18.8%) when using node-libzim seems to be calls to v8::internal::Builtin_HandleApiCall.

I'm not sure how much it would improve the performance, but we could try creating an addArticles method in CPP and automatically batch the adding on the JS side.
This would keep the same simple API, but potentially improve performance

@kelson42
Copy link
Contributor

@ISNIT0 Have a look to nodejs/node#17996, might be completely insignificant.

@ISNIT0
Copy link
Contributor Author

ISNIT0 commented May 22, 2019

@kelson42 in that issue, the total percentage was 0.1%, in our case it's 18.8%, so I think it matters much more for us 😀

@kelson42 kelson42 pinned this issue Nov 22, 2020
@kelson42
Copy link
Contributor

@audiodude Do you have some kind of insight on this. Actually I had forgotten about this issue, and that might be a good way to speed-up MWoffliner.

@audiodude
Copy link
Member

I'm not sure. I think mwoffliner will continue to be I/O bound because of all the network calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants