Wizard: switch snapshot date in wizard to RFC3339

[xbhouse]

The changes here should format the requested date from YYYY-MM-DD to RFC3339 in the snapshot step of the wizard. This helps content-sources clean up some tech debt and allows us to use RFC3339 for all date formats in our template-related APIs.

Background:
This PR removed support for YYYY-MM-DD in the request for /snapshots/for_date/ and broke things. The snapshot step in the wizard needed to be converted to use RFC3339 also. This commit has been reverted and things are good again.

Without these changes in the wizard, errors like this would be seen when calling /snapshots/for_date/ from the content sources API with an unsupported date format:

parsing time \"2024-10-18\" as \"2006-01-02T15:04:05Z07:00\": cannot parse \"\" as \"T\", internal=parsing time \"2024-10-18\" as \"2006-01-02T15:04:05Z07:00\": cannot parse \"\" as \"T\" \n

[app-sre-bot]

Can one of the admins verify this patch?

[xbhouse]

issue here

[croissanne]

Thank you!

Could you edit the commit message? The PR title is good. https://osbuild.org/docs/developer-guide/general/workflow#preferred-commit-message-format

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (e593445) to head (94326cb).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2526      +/-   ##
==========================================
- Coverage   84.86%   84.86%   -0.01%     
==========================================
  Files         183      183              
  Lines       20777    20783       +6     
  Branches     2016     2018       +2     
==========================================
+ Hits        17633    17638       +5     
- Misses       3122     3123       +1     
  Partials       22       22              

Files with missing lines	Coverage Δ
...teImageWizard/steps/Review/ReviewStepTextLists.tsx	94.64% <100.00%> (+0.01%)	⬆️
...ents/CreateImageWizard/steps/Snapshot/Snapshot.tsx	97.29% <100.00%> (-0.08%)	⬇️
src/store/wizardSlice.ts	89.10% <100.00%> (+0.09%)	⬆️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e593445...94326cb. Read the comment docs.

[xbhouse]

@croissanne this is ready for another review when you have a chance!

also, you mentioned image-builder needing an update to move from YYYY-MM-DD to RFC3339 too? let me know if there is anywhere else that will need a change as well, tracking them all here

[ochosi]

Looks like this has been stale for a bit, but it also seems to me that this should still be addressed, no?

[xbhouse]

@ochosi agreed, this lets us remove some tech debt from content-sources. i believe there are some changes needed in image-builder and maybe IQE tests too? i'm not sure which would need to be merged first. CC @croissanne

[regexowl]

Hey @xbhouse this looks great, thank you! pr_check is passing so IQE should be hopefully fine. @jrusz what do you think? Could changing the snapshot date format break something outside of pr_check? As for API, it looks like we're all set there: osbuild/image-builder#1252

[jrusz]

Hey @xbhouse this looks great, thank you! pr_check is passing so IQE should be hopefully fine. @jrusz what do you think? Could changing the snapshot date format break something outside of pr_check? As for API, it looks like we're all set there: osbuild/image-builder#1252

We have a specific function to convert between the api and ui format in IQE plugin so it will most likely need some adjustment, that's going to be an easy change though

[regexowl]

@xbhouse Could you please squash the commits and rebase? The changes look great ✨

@jrusz @tkoscieln This will be good to merge, could you please take a look at what changes will be needed and let me know when they're ready?

[tkoscieln]

@jrusz @tkoscieln This will be good to merge, could you please take a look at what changes will be needed and let me know when they're ready?

Let me catch up on this change and I'll make the adjustment in IQE tests

[jrusz]

/retest

[tkoscieln]

@xbhouse It seems this is not ready to merge yet. I tested it out and got a 500 code when trying to start the composes with a following error:

"errors": [
    {
      "detail": "Unable to build customizations: code=400, message=Snapshot date 2024-12-03T00:00:00.000Z is not in DateOnly (yyyy-mm-dd) format",
      "title": "500"
    }
  ]
  

@regexowl produced a fix for it here in backend.

[xbhouse]

@xbhouse It seems this is not ready to merge yet. I tested it out and got a 500 code when trying to start the composes with a following error:

"errors": [
    {
      "detail": "Unable to build customizations: code=400, message=Snapshot date 2024-12-03T00:00:00.000Z is not in DateOnly (yyyy-mm-dd) format",
      "title": "500"
    }
  ]
  

@regexowl produced a fix for it here in backend.

ooh ok, nice catch! thank you ❤️

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

[regexowl]

The backend fix got merged! Trying to compose an image and all looks good so far. @tkoscieln could you please take a look at the IQE test adjustment?

[tkoscieln]

@regexowl I tested it out, the compose works fine and I tried running the integration tests on it (as those are the ones that test the snapshotting) and they passed fine, so it seems this change is good to go.

[regexowl]

@tkoscieln Excellent, thank you! I'd say we're ready to merge then.

I believe everything was addressed.

[regexowl]

Thank you! ❤️

[xbhouse]

thank you all for your help on this!! i'm going to switch the date format to just RFC3339 in content-sources next (currently we're supporting both RFC3339 and YYYY-MM-DD), so once that's merged i'll monitor for any issues but hopefully everything goes smoothly 🙏

[regexowl]

Thank you! Please let me know if anything seems amiss.