Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wizard: add user name validation (HMS-5285) #2716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgold1234
Copy link
Collaborator

@mgold1234 mgold1234 commented Jan 5, 2025

this commit add validation to name field in Users step

JIRA: HMS-5285

@mgold1234 mgold1234 marked this pull request as draft January 5, 2025 20:27
@mgold1234 mgold1234 force-pushed the add_validation_name branch 2 times, most recently from d3d3c2d to ccc9774 Compare January 6, 2025 07:25
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (224b927) to head (ee76643).

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2716      +/-   ##
==========================================
+ Coverage   84.86%   84.88%   +0.01%     
==========================================
  Files         183      183              
  Lines       20795    20820      +25     
  Branches     2019     2025       +6     
==========================================
+ Hits        17648    17673      +25     
  Misses       3125     3125              
  Partials       22       22              
Files with missing lines Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx 99.47% <100.00%> (+<0.01%) ⬆️
...eateImageWizard/steps/Users/component/UserInfo.tsx 93.90% <100.00%> (-0.15%) ⬇️
...ents/CreateImageWizard/utilities/useValidation.tsx 97.66% <100.00%> (+0.24%) ⬆️
src/Components/CreateImageWizard/validators.ts 94.44% <100.00%> (+0.54%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224b927...ee76643. Read the comment docs.

@mgold1234 mgold1234 force-pushed the add_validation_name branch 8 times, most recently from 79e39b7 to 7b8f6cb Compare January 8, 2025 10:59
@mgold1234 mgold1234 changed the title <wip>- Add validation name wizard: add user name validation (HMS-4903) Jan 8, 2025
@mgold1234 mgold1234 marked this pull request as ready for review January 8, 2025 11:00
@mgold1234 mgold1234 requested review from lucasgarfield and regexowl and removed request for lucasgarfield January 8, 2025 11:00
@mgold1234 mgold1234 force-pushed the add_validation_name branch from 7b8f6cb to 6dc10b7 Compare January 8, 2025 11:16
@mgold1234 mgold1234 marked this pull request as draft January 8, 2025 11:33
@mgold1234
Copy link
Collaborator Author

/jira-epic HMS-4181

@mgold1234 mgold1234 force-pushed the add_validation_name branch from 6dc10b7 to 5d2940d Compare January 8, 2025 13:49
@mgold1234 mgold1234 marked this pull request as ready for review January 8, 2025 14:28
@mgold1234
Copy link
Collaborator Author

/jira-epic HMS-4181

@regexowl regexowl changed the title wizard: add user name validation (HMS-4903) wizard: add user name validation Jan 8, 2025
@regexowl
Copy link
Collaborator

regexowl commented Jan 8, 2025

/jira-epic HMS-4181

@schutzbot schutzbot changed the title wizard: add user name validation wizard: add user name validation (HMS-5285) Jan 8, 2025
@mgold1234 mgold1234 force-pushed the add_validation_name branch from 5d2940d to 0fc0e67 Compare January 9, 2025 09:20
this commit add validation to name field in Users step

JIRA: HMS-4903
@mgold1234 mgold1234 force-pushed the add_validation_name branch from 0fc0e67 to ee76643 Compare January 9, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants