Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wizard: create new component with eyeIcon button inside textInput (HMS-5289) #2727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgold1234
Copy link
Collaborator

@mgold1234 mgold1234 commented Jan 8, 2025

this commit create new component with eyeIcon button inside textInput,
for password field
Screenshot 2025-01-09 at 13 21 59

JIRA: HMS-5289

@mgold1234 mgold1234 marked this pull request as draft January 8, 2025 12:31
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 88.13559% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (224b927) to head (058c759).

Files with missing lines Patch % Lines
...omponents/CreateImageWizard/ValidatedTextInput.tsx 89.79% 5 Missing ⚠️
...eateImageWizard/steps/Users/component/UserInfo.tsx 80.00% 2 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2727   +/-   ##
=======================================
  Coverage   84.86%   84.87%           
=======================================
  Files         183      183           
  Lines       20795    20851   +56     
  Branches     2019     2027    +8     
=======================================
+ Hits        17648    17697   +49     
- Misses       3125     3132    +7     
  Partials       22       22           
Files with missing lines Coverage Δ
...eateImageWizard/steps/Users/component/UserInfo.tsx 92.30% <80.00%> (-1.74%) ⬇️
...omponents/CreateImageWizard/ValidatedTextInput.tsx 93.00% <89.79%> (-1.68%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224b927...058c759. Read the comment docs.

@lucasgarfield
Copy link
Collaborator

Some inspiration for you, we should try to follow PF as closely as possible:
https://v5-archive.patternfly.org/components/password-generator

@mgold1234 mgold1234 force-pushed the extend_button_pass branch 2 times, most recently from 506aea1 to 64b640c Compare January 9, 2025 11:20
@mgold1234 mgold1234 changed the title <wip> - extend TextInput with button wizard: create new component with add eyeIcon button inside textInput Jan 9, 2025
@mgold1234
Copy link
Collaborator Author

/jira-epic HMS-4181

@schutzbot schutzbot changed the title wizard: create new component with add eyeIcon button inside textInput wizard: create new component with add eyeIcon button inside textInput (HMS-5289) Jan 9, 2025
@mgold1234 mgold1234 marked this pull request as ready for review January 9, 2025 11:21
@mgold1234 mgold1234 changed the title wizard: create new component with add eyeIcon button inside textInput (HMS-5289) wizard: create new component with eyeIcon button inside textInput (HMS-5289) Jan 9, 2025
this commit create new component with add eyeIcon button inside textInput,
for password field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants