Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImagesTable: Fix version filter (HMS-5281) #2728

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 8, 2025

This fixes the "All versions" / "Newest" filter in the blueprint images table.

JIRA: HMS-5281

@regexowl
Copy link
Collaborator Author

regexowl commented Jan 8, 2025

/jira-epic HMS-5279

@schutzbot schutzbot changed the title ImagesTable: Fix version filter ImagesTable: Fix version filter (HMS-5281) Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (34b4f24) to head (2e1ff9c).

Files with missing lines Patch % Lines
src/Components/ImagesTable/ImagesTable.tsx 83.33% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
- Coverage   84.83%   84.82%   -0.01%     
==========================================
  Files         183      183              
  Lines       20820    20824       +4     
  Branches     2019     2020       +1     
==========================================
+ Hits        17662    17664       +2     
- Misses       3136     3138       +2     
  Partials       22       22              
Files with missing lines Coverage Δ
src/Components/ImagesTable/ImagesTable.tsx 92.19% <83.33%> (-0.42%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b4f24...2e1ff9c. Read the comment docs.

Copy link
Collaborator

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This fixes the "All versions" / "Newest" filter in the blueprint images table.
@regexowl regexowl force-pushed the fix-version-filter branch from 2e1ff9c to 4aa81eb Compare January 8, 2025 14:11
@regexowl regexowl enabled auto-merge (rebase) January 8, 2025 14:12
@regexowl
Copy link
Collaborator Author

regexowl commented Jan 8, 2025

/retest

2 similar comments
@regexowl
Copy link
Collaborator Author

regexowl commented Jan 8, 2025

/retest

@regexowl
Copy link
Collaborator Author

regexowl commented Jan 8, 2025

/retest

@regexowl regexowl merged commit d3e76c6 into osbuild:main Jan 8, 2025
6 checks passed
@regexowl regexowl deleted the fix-version-filter branch January 9, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants