Wizard: Add kernel append input (HMS-5299) #2734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/jira-epic HMS-5192 |
This is in a preparation to expose kernel append customization. It will be easier to mutate kernel append if it's represented as an array of arguments, rather than currently used string.
This adds the kernel append input. New arguments can be added by pressing the "Add" button or hitting Enter after the argument. The kernel arguments linked to a selected OpenSCAP profile are rendered in a category marked as "Required by OpenSCAP" and are read only.
schutzbot
changed the title
regexowl
force-pushed
the
kernel-append-input
branch
from
6199c02 to
418f4aa
Compare
This removes kernel append from the list of information about the selected OpenSCAP step.
This adds basic tests for kernel append.
regexowl
force-pushed
the
kernel-append-input
branch
from
418f4aa to
265fa11
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2734 +/- ##
==========================================
- Coverage 84.86% 84.85% -0.01%
==========================================
Files 183 183
Lines 20795 20947 +152
Branches 2019 2044 +25
==========================================
+ Hits 17648 17775 +127
- Misses 3125 3150 +25
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the kernel append input, removes kernel append from the OpenSCAP step and adds basic tests to cover the functionality.
JIRA: HMS-5299