Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vending_machine "RMV" seems problematic #10339

Open
mp747474 opened this issue Jan 14, 2025 · 4 comments
Open

vending_machine "RMV" seems problematic #10339

mp747474 opened this issue Jan 14, 2025 · 4 comments
Labels
fix data Need to cleanup the data in OSM after this is released

Comments

@mp747474
Copy link

The entry for vending_machine with name "RMV" is problematic for a number of reasons:

  • RMV is the name of what is called in German a "Verkehrsverbund" (transit district) so it's the kind of information that is normally tagged as network= not brand=, as we already do for bus and train lines.
  • "RMV" is an abbreviation for the full name "Rhein-Main-Verkehrsverbund". A while ago it was decided that we no longer use abbreviated names for Verkehrsverbünde, because the abbreviation can be ambiguous (until 2025 two Verkehrsverbünde in Germany had the exact same abbreviation)
  • In practice all of these vending machines are dual labeled RMV and DB (Deutsche Bahn), as they sell both local tickets for the local transit district (RMV), as well as Deutsche Bahn tickets for long-distance travel.
  • The entry tries to set name=, but we do not put names on vending machines.
@Snowysauce Snowysauce added the fix data Need to cleanup the data in OSM after this is released label Jan 14, 2025
@Snowysauce
Copy link
Collaborator

We can adjust the preset to address some of the listed issues, but OSM has enough instances of the "brand" that we can't simply delete the preset - it will just reappear the next time that the build script is run. (See #10346 (comment) for a more detailed explanation.)

I do agree that this preset seems out of place in the brands tree; ticket vending machines tend to be in the operators tree under whatever entity operates the machine.

@mp747474
Copy link
Author

Thanks for the heads-up. This seems to be the work of a single user who has added vending machines with name=, which then apparently made it into NSI as a brand, and from there iD added the brand tagging to these vending machines. This should be fixable by informing the user and then making an automated edit to fix the vending machines.

@mp747474
Copy link
Author

@Snowysauce This should be good to go now (the two gas stations in Czech Republic are unrelated)

Snowysauce added a commit that referenced this issue Jan 17, 2025
@Snowysauce
Copy link
Collaborator

Although the instances have been eliminated, unfortunately the NSI can't detect that until the NSI Collector project publishes a new dataset. (Despite the similar names, it runs somewhat independently from the NSI.) The most we can do right now is add "RMV" to the exclude Array of the category file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix data Need to cleanup the data in OSM after this is released
Projects
None yet
Development

No branches or pull requests

2 participants