Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement requestFilter's as per pact-js #107

Open
thakkarjinal opened this issue Jun 19, 2019 · 6 comments
Open

Feature: Implement requestFilter's as per pact-js #107

thakkarjinal opened this issue Jun 19, 2019 · 6 comments
Labels
area:v2 Relating to v2 code difficulty:medium A moderate task requiring a good understanding of the codebase type:feature New feature

Comments

@thakkarjinal
Copy link

Hi,
I am developing pact tests for my code and I am stuck at a place where I need a way to dynamically create authentication based on certain properties of the request.
My consumer is an angular app and provider a django app. I am aware that requestFilter has been implemented in pact-js which is exactly what I was looking for. This is where I read about it.
Would love to have something similar in python too.
Thanks!

@Sankalan13
Copy link

Facing a similar problem. Does the team have someone working on updating pact-python as the underlying Ruby is updated?
@mefellows @bethesque

@mefellows
Copy link
Member

This doesn't relate to the underlying Ruby, and is simply additional behaviour added to Pact JS to support this capability.

It would be a direct enhancement to Pact Python to make this happen.

@ChengLiPP
Copy link

I know this is an old thread, but is anything going to happen with this missing feature?

@bethesque
Copy link
Member

@elliottmurray might be interested if he has time. Matt or I can explain what is needed.

@ivanmikhalka
Copy link

ivanmikhalka commented Mar 4, 2023

Still interested in such feature, especially when working with contracts from pact broker.

@YOU54F
Copy link
Member

YOU54F commented May 3, 2023

Anyone is welcome to try and implement this, pact-js serves as a good example. pact-jvm and other languages alos have the feature.

If you would like any guidance, please let us know

I know this is an old thread, but is anything going to happen with this missing feature?

You could implement it and propose a PR @ChengLiPP, same applies to the other posters and requestors

@YOU54F YOU54F added good first issue Good for newcomers feature request type:feature New feature labels Aug 3, 2023
@YOU54F YOU54F changed the title Feature similar to requestFilter in pact-js Feature: Implement requestFilter's as per pact-js Aug 3, 2023
@JP-Ellis JP-Ellis added area:v2 Relating to v2 code difficulty:medium A moderate task requiring a good understanding of the codebase and removed good first issue Good for newcomers labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:v2 Relating to v2 code difficulty:medium A moderate task requiring a good understanding of the codebase type:feature New feature
Projects
None yet
Development

No branches or pull requests

8 participants