Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST(string dtype): Resolve xfails in test_to_csv #60683

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Jan 9, 2025

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Current behavior of these tests is correct, for most we start with object dtype and then roundtripping through to_csv we end up with a StringDtype. Modifying tests so the input starts as StringDtype.

@rhshadrach rhshadrach added Testing pandas testing functions or related to the test suite IO CSV read_csv, to_csv Strings String extension data type and string data labels Jan 9, 2025
@WillAyd WillAyd added this to the 2.3 milestone Jan 9, 2025
@WillAyd WillAyd merged commit 4693d1a into pandas-dev:main Jan 9, 2025
51 checks passed
@WillAyd
Copy link
Member

WillAyd commented Jan 9, 2025

Awesome thanks @rhshadrach

Copy link

lumberbot-app bot commented Jan 9, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4693d1a000f34641f8215caea6872b3357f4db76
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60683: TST(string dtype): Resolve xfails in test_to_csv'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60683-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60683 on branch 2.3.x (TST(string dtype): Resolve xfails in test_to_csv)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@WillAyd
Copy link
Member

WillAyd commented Jan 9, 2025

backport PR is #60687

mroeschke pushed a commit that referenced this pull request Jan 9, 2025
@rhshadrach rhshadrach deleted the str_xfail_to_csv branch January 9, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants