Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: dependency on /dev/disk/by-label and faulty logic #2

Open
macropin opened this issue Oct 4, 2023 · 0 comments
Open

Bug: dependency on /dev/disk/by-label and faulty logic #2

macropin opened this issue Oct 4, 2023 · 0 comments

Comments

@macropin
Copy link
Member

macropin commented Oct 4, 2023

There are actually two bugs / interrelated issues here:

  1. Requires /dev/disk/by-label/ to evaluate disks. (This does not exist on earlier Alpine versions and IMHO is a poor way to evaluate disks.)
  2. CheckFilesystem returns non error if the filesystem already exists and is the same type as desired.

When the two of these are combined, you get a situation where GOAT will format a disk that contains data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macropin