Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulus: gossip block announcement before import #5255

Closed
sandreim opened this issue Aug 6, 2024 · 5 comments
Closed

Cumulus: gossip block announcement before import #5255

sandreim opened this issue Aug 6, 2024 · 5 comments
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T9-cumulus This PR/Issue is related to cumulus.

Comments

@sandreim
Copy link
Contributor

sandreim commented Aug 6, 2024

Currently my understanding is that we don't gossip the block announcement until we have imported it successfully.

For elastic scaling parachains this works fine as long as the next block author is directly connected to the current one. If they are not directly connected, the announcement will arrive much later to the next author: number_of_hops x import_duration. This leads to the next author creating a fork and stalling the progress of the parachain.

CC @skunert

@sandreim sandreim added I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T9-cumulus This PR/Issue is related to cumulus. labels Aug 6, 2024
@skunert
Copy link
Contributor

skunert commented Aug 6, 2024

Yes, there is this issue #65 together with a previous solving attempt paritytech/substrate#8052 . However have not looked into the details what the exact problems with previous attempt were.

@burdges
Copy link

burdges commented Aug 8, 2024

Is this required even if the same collator builds the whole batch of elastic scalled blocks? Aka it's so the other parachain nodes can keep up?

@sandreim
Copy link
Contributor Author

sandreim commented Aug 8, 2024

It is only required when the author of the next block is different from current one. With AURA it will always be needed, unless there is just a single collator, or we make changes so each author gets more than one slot to author.

@sandreim
Copy link
Contributor Author

sandreim commented Aug 8, 2024

Other nodes should keep up just fine, they don’t need to do anything special.

@bkchr
Copy link
Member

bkchr commented Aug 12, 2024

Duplicate of #65.

@bkchr bkchr closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Development

No branches or pull requests

4 participants