Remove dead code #17632
Open
Remove dead code #17632
+26
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove #items from DTReRunConfiguration because this is never called (I checked) and calls dead code - Remove printing methods from KeyMapping because they call dead code, cannot work and are never called - Fix deprecation in SpRubFindReplaceDialog Fixes pharo-project#17606 Fixes pharo-project#17609
This allowed to be able to edit string morph but currently there is no sender of this feature and it calls dead code. Thus, it means that this feature is not working. Since we plan to remove Morphic I think it is safe to remove this broken feature
|
Thanks cyril. |
|
There are multiple printing methods and those ones are not called. Tests are passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17603
Fixes #17606
Fixes #17609