Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Avoid duplicate data preparation #3

Open
SarahAlidoost opened this issue Aug 25, 2023 · 0 comments · May be fixed by #4
Open

Avoid duplicate data preparation #3

SarahAlidoost opened this issue Aug 25, 2023 · 0 comments · May be fixed by #4

Comments

@SarahAlidoost
Copy link
Member

PR #1 adds a wrapper for the thermaltime model and transforms the incoming data (sklearn compatible (X, y)) to the structure understood by pyphenology see https://pyphenology.readthedocs.io/en/master/data_structures.html#phenology-environmental-data. Then inside pyphenology we go back to sklearn data structure see temperature_only_data_prep. We should explore if we can skip the internal transformation for all models, especially M1 and Naive that use other predictors besides daily mean temerature.

@SarahAlidoost SarahAlidoost linked a pull request Oct 16, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant