Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some emojis break the table layout #300

Closed
soywod opened this issue Feb 22, 2022 · 11 comments
Closed

Some emojis break the table layout #300

soywod opened this issue Feb 22, 2022 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@soywod
Copy link
Member

soywod commented Feb 22, 2022

Like 🏕️.

@soywod soywod added bug Something isn't working cli labels Feb 22, 2022
@TornaxO7
Copy link
Contributor

I have general suggestion here: Why are we not using a TUI-lib crate for printing out the table?

@soywod
Copy link
Member Author

soywod commented Feb 23, 2022

Because I did not find a decent one, plus the need was quite simple. I'm happy so far with the custom result!

@TornaxO7
Copy link
Contributor

Hm... ok. Because I was thinking about tui-rs with its table feature.
I don't know how much you know about tui-rs, but just in case:
We could configure it to print the table only once without starting a loop so we could leave the UI-logic to tui-rs.

@soywod
Copy link
Member Author

soywod commented Feb 23, 2022

I did not know about such feature in tui-rs, interesting! But I'm a bit afraid to compile and package all tui-rs just for the table feature. You can try a POC and see if you want!

@soywod
Copy link
Member Author

soywod commented Mar 2, 2022

@toastal
Copy link
Contributor

toastal commented Mar 2, 2022

Not blaming you but like... why are people putting emojis in their subjects? :\

@soywod
Copy link
Member Author

soywod commented Mar 2, 2022

Ask them 🤣 but often it is "commercial" emails, like recruitment or newsletters.

@soywod
Copy link
Member Author

soywod commented Mar 2, 2022

unicode-rs/unicode-width#27

I got a reply from there, it is not possible to always know the rendered width of an unicode. But I found out why some emoji break the table layout: there is special chars called variation selectors that are placed just after an emoji and can changed the appearance by selecting a variation of this same emoji. The work around I found is to remove such selectors from the table…

@soywod soywod closed this as completed Mar 2, 2022
@toastal
Copy link
Contributor

toastal commented Mar 2, 2022

Long-term: I'd like to see the ability to disable rendering emoji. It just looks bad and unnatural in my terminal.

@soywod
Copy link
Member Author

soywod commented Jan 1, 2025

I re-open the issue, as it seems to be broken again since the use of comfy-table, see Nukesor/comfy-table#53 #497.

@soywod soywod reopened this Jan 1, 2025
@soywod soywod added this to Pimalaya Jan 1, 2025
@soywod soywod moved this to Todo in Pimalaya Jan 1, 2025
@soywod soywod self-assigned this Jan 1, 2025
@soywod
Copy link
Member Author

soywod commented Jan 2, 2025

Closing back, since the issue comes from terminal emulators in general.

@soywod soywod closed this as completed Jan 2, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Pimalaya Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants