-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Add RTL layout support to the sidebar #3689
Comments
Could you try this?
This workaround should be added to the code snippets for now, if it is effective enough, |
And I hope to put this code into TST as a built-in, if it is possible to detect the global direction of the browser UI. Hmm, how should we do that...? |
The addition to the user style sheet seems to solve the problem! Thank you. |
Two bugs I noticed with this implementation, though:
|
I've researched how Firefox itself applies RTL layout. It uses |
I've introduced some changes to support RTL environment. Could you try the latest development build and remove the CSS hack I posted before? |
Looking very good! |
I've pushed more changes to improve RTL support. I'm waiting for your more feedback! |
Reminder:
|
Helper addons ( |
It seems that I'll need to replace my entire firefox installation in order to install an unsigned addon, as the one that is produced by the automated build... |
Automated unsigned builds can be loaded temporarily with about:debugging, on regular releases of Firefox. Anyway I've uploaded a new release 4.1.1 including this change. Please wait until it is published after reviewed. |
Abstract
RTL users can move the sidebar to the right hand side of the firefox window, but its inner layout is still LTR, which is uncomfortable and unintuitive. We need an RTL layout support for the sidebar.
Steps to see the situation
Expected result
The pinned tabs should be aligned to the right.
The icon on each tab should be on its right.
The triangle for spreading a parent tab should be on its right.
Nested tabs should be moved slightly to the left.
The X closing button on each tab should be on its left.
Actual (present) result
The pinned tabs are aligned to the left.
The icon on each tab is on its left.
The triangle for spreading a parent tab is on its left.
Nested tabs are moved slightly to the right.
The X closing button on each tab is on its right.
Environment
The text was updated successfully, but these errors were encountered: