For single file field, "Add File" should say "Replace File" and hebavior needs update accordingly

[heybran]

Description

For single file field, Add File should say Replace File and hebavior needs update accordingly.

As discussed on Slack, the way it works now is that it's just attempting to add the additional file but it has hit the limit so newly added file won't be shown, we should update Add File to Replace File and update button function to replace file as well.

Version

2.9.19

Screenshots / Screencast

[JoryHogeveen]

I believe this is a field setting, you can set your own label in the field advanced options.

[sc0ttkclark]

This is really tough because the file field needs a full refactor. It's currently in an in-between state because we tried to save money in our original React revamp for Pods 2.8.

It's got a Marionette adapter sitting on top of the React field and the logic is really difficult to rework.

As it stands, if we change how this works for 'Single' file fields to replace the existing value, that may be confusing since 'Multiple' file fields won't have that ability. So for 'Single', if we used 'Replace' then 'Multiple' would have a different interaction there.

[heybran]

Hey @sc0ttkclark

I've sent a small improvement PR for this issue: #7315, although didn't really refactor the logic to make the All file to replace original file if it's a single file field, but what I did is to hide the button when an file is being added already, so in my opinion that would be better than current behavior. What do you think?