Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 22 Compat #56

Open
nikeee opened this issue Jan 3, 2025 · 2 comments
Open

Node.js 22 Compat #56

nikeee opened this issue Jan 3, 2025 · 2 comments

Comments

@nikeee
Copy link

nikeee commented Jan 3, 2025

Is it planned to support Node 22+?

On Node 23, there is a build error:

npm error ../../../nan/nan.h: In function ‘void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, GetterCallback, SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, imp::Sig)’:
npm error ../../../nan/nan.h:2548:8: error: ‘class v8::ObjectTemplate’ has no member named ‘SetAccessor’
npm error  2548 |   tpl->SetAccessor(
@nikeee
Copy link
Author

nikeee commented Jan 3, 2025

It seems that this depends on nodejs/nan#979

@nikeee
Copy link
Author

nikeee commented Jan 10, 2025

It seems to work in 23.6.0. I'll do more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant