Errors in renderToPipeableStream crash Node.js process #404
Comments
|
Minimally reproducible example const { h } = require("preact");
const { renderToPipeableStream } = require("preact-render-to-string/stream-node");
function MyComponent() {
const a = aaa // ReferenceError
}
try {
const stream = renderToPipeableStream(h(MyComponent), {
onError(e) {
// doesn't catch the error
console.error("caught error", e);
},
});
// can't do stream.on("error") because the actual PassThrough stream isn't exposed
} catch (e) {
// doesn't catch the error
console.log("caught error", e);
} |
|
fwiw I checked this same code with React 19 and the ReferenceError is passed to the user-provided |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Inside
renderToPipeableStream, any errors thrown inrenderToChunksare caught, and then used to destroy the streampreact-render-to-string/src/stream-node.js
Lines 46 to 48 in 2da38a7
Calling
abort()will also destroy the stream with an error.Destroying the stream emits an
'error'event on the PassThrough stream, and because there's no error handler attached to that stream, this crashes the entire process (see stacktrace below). This stream isn't exposed (only used through thepipe(writable)wrapper function), so consumers are unable to add an error handler for this themselves.(Error caused by a reference error inside the Preact component that's being rendered)
There could be an internal error handler attached to the stream which ensures the process doesn't crash, and could call the existing
options.onError()hook (or a differently named error callback).Or the raw
streamcould be returned fromrenderToPipeableStreamso users can add the error handler themselves, or even use the stream with the more modernstream.pipelinemethod, which also makes it easier to handle errors properly.The latter would also allow directly setting
response.body = streamwhen used with the koa webserver.The text was updated successfully, but these errors were encountered: