Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up EstimatorReport: add an ADR for the design of EstimatorReport #1071

Open
glemaitre opened this issue Jan 10, 2025 · 2 comments
Open
Assignees

Comments

@glemaitre
Copy link
Member

We could write an ADR for the EstimatorReport to document some design choices and some additional vision. It would be useful for future maintenance and subsequent design.

@glemaitre glemaitre self-assigned this Jan 10, 2025
@augustebaum
Copy link
Contributor

Questions which arose during the presentation yesterday, along with what I understood the answers to be:

Why not compute and cache everything upfront, instead of exposing an explicit reporter.cache_predictions() method?

Answer: Just in case the estimator takes a long time to do things

Why do the metrics methods return pandas DataFrames?

Answer: So that the DFs can be concatenated and chained (e.g. using pandas' .plot)

Why accessors rather than hard-coding?

Answer: Accessors fit the problem better

@glemaitre
Copy link
Member Author

Thanks @augustebaum, I'll integrate those points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants