-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance skore.cross_validate
: specify which metric is actually used behind test_score
#578
Comments
test_r2
and test_score
.skore.cross_validate
, specify which metric is actually used behind test_score
skore.cross_validate
, specify which metric is actually used behind test_score
skore.cross_validate
: specify which metric is actually used behind test_score
So would we show this information in the plot? Or does it also have to be in the output of |
How exactly should we give this information? In the title of the plot? |
Hmm subtitle of the plot? |
We need to address this, mentioned today in #1047 |
In the case of the regression task, let's just display WDYT? Cc @augustebaum @MarieS-WiMLDS |
I like the star idea because it's pretty, but is it technically possible to have an emoji in the legend? Plus, it is explicit? The other less pretty option but explicit and easy would be to print sth like |
(We could use unicode emoji / characters that should work in matplotlib, etc, as done in #997) After discussing with @glemaitre, this issue is on hold, waiting on #997 and #1014 as they will change the way a cross-validation report is displayed |
Problem
Part of epic #544
When using
skore.cross_validate
with linear regression for example, I can see the following scores in the legend:test_score
andr2_score
, while thetest_score
is actually ther2_score
! This can be confusing for the user.Suggested solution
It is ok the keep
test_score
andr2_score
, but in any case, tell the user which score is actually used by default by scikit-learn for thetest_score
(it depends on each estimator).The text was updated successfully, but these errors were encountered: