fix: Fix variable fonts in WebGL mode #7459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes processing#7447 Update `FontInfo` class in `src/webgl/text.js` to account for variable font changes and cache by variable value. * Add `variableFontCache` to `FontInfo` class to store variable font data. * Modify `getGlyphInfo` method to use cache key based on glyph index and variable values. * Adjust `getGlyphInfo` method to return cached glyph info based on cache key. * Update initialization of glyph info to use cache key. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/processing/p5.js/issues/7447?shareId=XXXX-XXXX-XXXX-XXXX).
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
|
Please verify my pr and let me know if any change is required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7447
Update
FontInfoclass insrc/webgl/text.jsto account for variable font changes and cache by variable value.variableFontCachetoFontInfoclass to store variable font data.getGlyphInfomethod to use cache key based on glyph index and variable values.getGlyphInfomethod to return cached glyph info based on cache key.For more details, open the Copilot Workspace session.